.github/scripts/bot-assignment-check.sh (1)

57-60: ⚠️ Potential issue | 🔴 Critical

gh api --jq --arg is invalid here and can silently undercount assignments.

Line 57 passes --arg as if it were a gh api flag. On failure, || echo 0 converts the error into a zero count, which can incorrectly allow extra triage assignments.

Proposed fix

-     gh api "repos/${REPO}/issues?per_page=100&page=1" \
-       -f assignee="${ASSIGNEE}" \
-       -f state=open \
-       --jq --arg mentor_label "$MENTOR_LABEL" '.[]
-            | select(.pull_request == null)
-            | select(any(.labels[]; .name == $mentor_label) | not)
-            | .number' | grep -c . || echo 0
+     gh api "repos/${REPO}/issues?per_page=100&page=1" \
+       -f assignee="${ASSIGNEE}" \
+       -f state=open \
+       | jq -r --arg mentor_label "$MENTOR_LABEL" '
+            [.[]
+             | select(.pull_request == null)
+             | select(any((.labels // [])[]; .name == $mentor_label) | not)
+            ] | length
+         '

#!/bin/bash
set -euo pipefail

echo "== gh api supported flags =="
gh api --help | rg -n -- '--jq|--arg' || true

echo
echo "== reproduce option parsing behavior =="
set +e
gh api repos/cli/cli/issues --jq --arg mentor_label test '.[].number' 2>&1 | sed -n '1,6p'
status=$?
set -e
echo "exit_status=${status}"

.github/scripts/bot-assignment-check.sh (1)

54-60: ⚠️ Potential issue | 🔴 Critical

gh api --jq still doesn't accept --arg; the triage count is silently zero.

Despite the previous review being marked as addressed, the current code still passes --arg mentor_label "$MENTOR_LABEL" directly as arguments to gh api --jq. The gh api --jq flag consumes only a single jq expression string and does not forward further flags to jq. At runtime this will fail with unknown flag: --arg (or treat --arg as the filter and fail to parse), and because the whole pipeline is guarded by || echo 0, the failure is masked and assignments_count silently returns 0 for every triage user — meaning mentors bypass the limit entirely.

Run through jq explicitly so --arg is honored:

🛠️ Proposed fix

-     gh api "repos/${REPO}/issues?per_page=100&page=1" \
-       -f assignee="${ASSIGNEE}" \
-       -f state=open \
-       --jq --arg mentor_label "$MENTOR_LABEL" '.[]
-            | select(.pull_request == null)
-            | select(any(.labels[]; .name == $mentor_label) | not)
-            | .number' | grep -c . || echo 0
+    gh api "repos/${REPO}/issues?per_page=100&page=1" \
+      -f assignee="${ASSIGNEE}" \
+      -f state=open \
+    | jq -r --arg mentor_label "$MENTOR_LABEL" '
+        .[]
+        | select(.pull_request == null)
+        | select(any((.labels // [])[]; .name == $mentor_label) | not)
+        | .number
+      ' | grep -c . || echo 0

Also worth decoupling the || echo 0 from grep -c (e.g., capture the pipeline status separately) so genuine API errors don't continue to be silently swallowed.

#!/bin/bash
# Confirm gh api --jq does not accept --arg
gh api --help 2>&1 | rg -nC2 -- '--jq|--arg' || true

.github/scripts/bot-assignment-check.sh (1)

54-60: ⚠️ Potential issue | 🔴 Critical

Fix gh api --arg; the triage count can silently become zero.

Line 57 still passes jq’s --arg flag to gh api, which does not support it. Because the pipeline ends with || echo 0, this can mask the CLI failure and allow over-assignment for triage users.

Proposed fix

-     gh api "repos/${REPO}/issues?per_page=100&page=1" \
-       -f assignee="${ASSIGNEE}" \
-       -f state=open \
-       --jq --arg mentor_label "$MENTOR_LABEL" '.[]
-            | select(.pull_request == null)
-            | select(any(.labels[]; .name == $mentor_label) | not)
-            | .number' | grep -c . || echo 0
+    gh api "repos/${REPO}/issues?per_page=100&page=1" \
+      -f assignee="${ASSIGNEE}" \
+      -f state=open \
+      | jq --arg mentor_label "$MENTOR_LABEL" '[
+          .[]
+          | select(.pull_request == null)
+          | select(any((.labels // [])[]; .name == $mentor_label) | not)
+        ] | length'

Verify the runner has the expected CLI behavior and jq available:

#!/bin/bash
set -euo pipefail

echo "== gh version =="
gh --version | sed -n '1p'

echo "== gh api jq-related flags =="
gh api --help | rg -n -- '--jq|--arg' || true

echo "== jq availability =="
command -v jq
jq --version